lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] iio: accel: fxls8962af: fix i2c dependency
    On Wed, Jul 21, 2021 at 6:13 PM Arnd Bergmann <arnd@kernel.org> wrote:
    >
    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > With CONFIG_SPI=y and CONFIG_I2C=m, building fxls8962af into vmlinux
    > causes a link error against the I2C module:
    >
    > aarch64-linux-ld: drivers/iio/accel/fxls8962af-core.o: in function `fxls8962af_fifo_flush':
    > fxls8962af-core.c:(.text+0x3a0): undefined reference to `i2c_verify_client'
    >
    > Work around it by adding a Kconfig dependency that forces the SPI driver
    > to be a loadable module whenever I2C is a module.

    ...

    > config FXLS8962AF
    > tristate
    > + depends on I2C || !I2C # cannot be built-in for modular I2C

    Can you enlighten me how this will not be a no-op?

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2021-07-21 17:52    [W:3.085 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site