lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] tty: nozomi: tty_unregister_device -> tty_port_unregister_device
On Wed, Jul 21, 2021 at 07:33:04PM +0800, Dongliang Mu wrote:
> The pairwise api invocation of tty_port_register_device should be
> tty_port_unregister_device, other than tty_unregister_device.

Are you sure about that? Please explain why you think this to be the
case and why this change is needed.

> Fixes: a6afd9f3e819 ("tty: move a number of tty drivers from drivers/char/ to drivers/tty/")

Please try a little harder, that's clearly not the commit that changed
to the port registration helper.

> Cc: stable@vger.kernel.org

Why do you think this is stable material? (hint: it is not)

> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> drivers/tty/nozomi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
> index 0c80f25c8c3d..08bdd82f60b5 100644
> --- a/drivers/tty/nozomi.c
> +++ b/drivers/tty/nozomi.c
> @@ -1417,7 +1417,8 @@ static int nozomi_card_init(struct pci_dev *pdev,
>
> err_free_tty:
> for (i--; i >= 0; i--) {
> - tty_unregister_device(ntty_driver, dc->index_start + i);
> + tty_port_unregister_device(&dc->port[i].port, ntty_driver,
> + dc->index_start + i);
> tty_port_destroy(&dc->port[i].port);
> }
> free_irq(pdev->irq, dc);

Johan

\
 
 \ /
  Last update: 2021-07-21 14:05    [W:0.087 / U:1.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site