lkml.org 
[lkml]   [2021]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/7] gpio: tqmx86: really make IRQ optional
    Date
    The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This
    causes warnings with newer kernels.

    Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a
    missing IRQ properly.

    Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller")
    Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
    ---

    v2: add Fixes line

    The "irq != -ENXIO" check can be removed again if
    platform_get_irq_optional() is modified to return 0 when no IRQ is
    found; the current code will work with both -ENXIO and 0 returns.


    drivers/gpio/gpio-tqmx86.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
    index 5022e0ad0fae..0f5d17f343f1 100644
    --- a/drivers/gpio/gpio-tqmx86.c
    +++ b/drivers/gpio/gpio-tqmx86.c
    @@ -238,8 +238,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
    struct resource *res;
    int ret, irq;

    - irq = platform_get_irq(pdev, 0);
    - if (irq < 0)
    + irq = platform_get_irq_optional(pdev, 0);
    + if (irq < 0 && irq != -ENXIO)
    return irq;

    res = platform_get_resource(pdev, IORESOURCE_IO, 0);
    @@ -278,7 +278,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)

    pm_runtime_enable(&pdev->dev);

    - if (irq) {
    + if (irq > 0) {
    struct irq_chip *irq_chip = &gpio->irq_chip;
    u8 irq_status;

    --
    2.17.1
    \
     
     \ /
      Last update: 2021-07-02 14:24    [W:3.204 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site