lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 225/351] watchdog: keembay: Removed timeout update in the TO ISR
    Date
    From: Shruthi Sanil <shruthi.sanil@intel.com>

    [ Upstream commit 3168be5d66ac6c3508a880022f79b5a887865d5d ]

    In the TO ISR removed updating the Timeout value because
    its not serving any purpose as the timer would have already expired
    and the system would be rebooting.

    Fixes: fa0f8d51e90d ("watchdog: Add watchdog driver for Intel Keembay Soc")
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Tested-by: Kris Pan <kris.pan@intel.com>
    Signed-off-by: Shruthi Sanil <shruthi.sanil@intel.com>
    Link: https://lore.kernel.org/r/20210517174953.19404-7-shruthi.sanil@intel.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/watchdog/keembay_wdt.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c
    index 039753b9932b..dd192b8dff55 100644
    --- a/drivers/watchdog/keembay_wdt.c
    +++ b/drivers/watchdog/keembay_wdt.c
    @@ -141,7 +141,6 @@ static irqreturn_t keembay_wdt_to_isr(int irq, void *dev_id)
    struct keembay_wdt *wdt = dev_id;
    struct arm_smccc_res res;

    - keembay_wdt_writel(wdt, TIM_WATCHDOG, 1);
    arm_smccc_smc(WDT_ISR_CLEAR, WDT_TO_INT_MASK, 0, 0, 0, 0, 0, 0, &res);
    dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt timeout.\n");
    emergency_restart();
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 19:49    [W:2.122 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site