lkml.org 
[lkml]   [2021]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 3/3] power: supply: mt6360_charger: add MT6360 charger support
    Hi,

    On Mon, May 31, 2021 at 11:39:50AM +0800, Gene Chen wrote:
    > > > +static int mt6360_charger_remove(struct platform_device *pdev)
    > > > +{
    > > > + struct mt6360_chg_info *mci = platform_get_drvdata(pdev);
    > > > +
    > > > + cancel_work_sync(&mci->chrdet_work);
    > > > +
    > > > + return 0;
    > > > +}
    > >
    > > Just as a note, devm_work_autocancel() should hopefully be included at
    > > next cycle. Then you might be able to drop the .remove().
    >
    > ACK, I will replace it, thanks.

    > > FWIW:
    > > Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

    Did I miss a newer revision?

    -- Sebastian
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-07-16 15:49    [W:3.160 / U:0.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site