lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH Part2 RFC v4 08/40] x86/traps: Define RMP violation #PF error code
From
Date
On 7/15/21 12:02 PM, Sean Christopherson wrote:
>> #ifndef _ASM_X86_TRAP_PF_H
>> #define _ASM_X86_TRAP_PF_H
>>
>> +#include <vdso/bits.h> /* BIT() macro */
> What are people's thoughts on using linux/bits.h instead of vdso.bits.h, even
> though the vDSO version is technically sufficient? Seeing the "vdso" reference
> definitely made me blink slowly a few times.

Ugh, missed that. Yes, that does look very weird.

I don't see any reason to use that vdso/ version instead of BIT_ULL().
I suspect I said to use BIT() when I commented on this in a previous
round. If so, that was wrong.

\
 
 \ /
  Last update: 2021-07-15 22:10    [W:2.294 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site