[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] HID: input: do not report stylus battery state as "full"
On Tue, 29 Jun 2021, Dmitry Torokhov wrote:

> The power supply states of discharging, charging, full, etc, represent
> state of charging, not the capacity level of the battery (for which
> we have a separate property). Current HID usage tables to not allow
> for expressing charging state of the batteries found in generic
> styli, so we should simply assume that the battery is discharging
> even if current capacity is at 100% when battery strength reporting
> is done via HID interface. In fact, we were doing just that before
> commit 581c4484769e.
> This change helps UIs to not mis-represent fully charged batteries in
> styli as being charging/topping-off.
> Fixes: 581c4484769e ("HID: input: map digitizer battery usage")
> Reported-by: Kenneth Albanowski <>
> Signed-off-by: Dmitry Torokhov <>

As there was no pushback from Bastien, I am queuing this for 5.15. Thanks,

Jiri Kosina

 \ /
  Last update: 2021-07-15 21:39    [W:0.330 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site