Messages in this thread Patch in this message | | | From | Bard Liao <> | Subject | [PATCH 05/10] soundwire: stream: don't abort bank switch on Command_Ignored/-ENODATA | Date | Wed, 14 Jul 2021 11:22:04 +0800 |
| |
This change is needed for support of mockup devices, which by construction will not provide any answer to a bank switch, but it's also legit for regular cases.
If for some reason a device loses sync and cannot handle a bank switch, we should go ahead anyways. The devices can always resync later.
The only case where the error flow should be used is when there is a Command_Aborted composite answer from SoundWire devices.
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@intel.com> --- drivers/soundwire/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index 1a18308f4ef4..d84aaf115c13 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -697,7 +697,7 @@ static int sdw_bank_switch(struct sdw_bus *bus, int m_rt_count) else ret = sdw_transfer(bus, wr_msg); - if (ret < 0) { + if (ret < 0 && ret != -ENODATA) { dev_err(bus->dev, "Slave frame_ctrl reg write failed\n"); goto error; } -- 2.17.1
| |