Messages in this thread | | | Date | Tue, 13 Jul 2021 08:58:11 +0200 | From | Greg KH <> | Subject | Re: [PATCH V5 1/1] misc: NOC Probe Counters |
| |
On Tue, Jul 13, 2021 at 12:23:47PM +0530, pandith.n@intel.com wrote: > --- /dev/null > +++ b/drivers/misc/noc/Kconfig > @@ -0,0 +1,16 @@ > +# Copyright (C) 2019 Intel Corporation > +# SPDX-License-Identifier: GPL-2.0-only > + > + > +config NOC_DSS > + tristate "Enable DSS NOC probing"
Please be more descriptive of what exactly this is, it does not make sense to anyone who does not know what DSS or NOC means.
> + depends on ARCH_KEEMBAY > + default y
You only use 'y' if the machine can not boot without the option. Otherwise it is left alone.
And what about CONFIG_TEST ability to test build this code? Without that, you will get almost no one every building this code to see if anything breaks over time.
thanks,
greg k-h
| |