Messages in this thread | | | Date | Tue, 13 Jul 2021 08:41:01 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] delete useless for loop |
| |
Hello Salah,
On Mon, Jul 12, 2021 at 09:58:48PM +0100, Salah Triki wrote: > Delete useless initialization of fst_card_array since the default > initialization is NULL. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > drivers/net/wan/farsync.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c > index b3466e084e84..0b3f561d5d5e 100644 > --- a/drivers/net/wan/farsync.c > +++ b/drivers/net/wan/farsync.c > @@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = { > static int __init > fst_init(void) > { > - int i; > - > - for (i = 0; i < FST_MAX_CARDS; i++) > - fst_card_array[i] = NULL; > return pci_register_driver(&fst_driver); > }
Looks right. I wonder if it makes sense to go even further and let farsync.c use module_pci_driver.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |