lkml.org 
[lkml]   [2021]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] perf tools: Fix build with libpfm
On Mon, Jul 12, 2021 at 4:49 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> It missed to update the parse_libpfm_events_option() to use a new
> helper function to set the event group leader.
>
> $ make LIBPFM4=1
> ...
> CC util/pfm.o
> util/pfm.c: In function ‘parse_libpfm_events_option’:
> util/pfm.c:103:9: error: ‘struct evsel’ has no member named ‘leader’
> 103 | evsel->leader = grp_leader;
> | ^~
> make[4]: *** [tools/build/Makefile.build:96: util/pfm.o] Error 1
>
> Fixes: fba7c86601e2 ("libperf: Move 'leader' from tools/perf to perf_evsel::leader")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/util/pfm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pfm.c b/tools/perf/util/pfm.c
> index dd9ed56e0504..756295dedccc 100644
> --- a/tools/perf/util/pfm.c
> +++ b/tools/perf/util/pfm.c
> @@ -99,7 +99,7 @@ int parse_libpfm_events_option(const struct option *opt, const char *str,
> grp_leader = evsel;
>
> if (grp_evt > -1) {
> - evsel->leader = grp_leader;
> + evsel__set_leader(evsel, grp_leader);
> grp_leader->core.nr_members++;
> grp_evt++;
> }
> --
> 2.32.0.93.g670b81a890-goog
>

\
 
 \ /
  Last update: 2021-07-13 22:13    [W:0.034 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site