Messages in this thread Patch in this message | | | Date | Tue, 13 Jul 2021 17:32:56 +0000 | From | Wei Liu <> | Subject | Re: [PATCH] Hyper-V: fix for unwanted manipulation of sched_clock when TSC marked unstable |
| |
On Tue, Jul 13, 2021 at 05:25:59PM +0000, Michael Kelley wrote: > From: Ani Sinha <ani@anisinha.ca> Sent: Monday, July 12, 2021 8:05 PM [...] > > /* > > @@ -432,6 +430,12 @@ static void __init ms_hyperv_init_platform(void) > > /* Register Hyper-V specific clocksource */ > > hv_init_clocksource(); > > #endif > > + /* TSC should be marked as unstable only after Hyper-V > > + * clocksource has been initialized. This ensures that the > > + * stability of the sched_clock is not altered. > > + */ > > For multi-line comments like the above, the first comment line > should just be "/*". So: > > /* > * TSC should be marked as unstable only after Hyper-V > * clocksource has been initialized. This ensures that the > * stability of the sched_clock is not altered. > */ > > > > + if (!(ms_hyperv.features & HV_ACCESS_TSC_INVARIANT)) > > + mark_tsc_unstable("running on Hyper-V"); > > } > > > > static bool __init ms_hyperv_x2apic_available(void) > > -- > > 2.25.1 > > Modulo the comment format, >
I can fix this while committing. No need to resend.
> Reviewed-by: Michael Kelley <mikelley@microsoft.com> > Tested-by: Michael Kelley <mikelley@microsoft.com>
Thanks Michael.
Wei.
| |