Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 12 Jul 2021 08:03:53 -0700 | Subject | Re: [v8 1/6] drm/panel: add basic DP AUX backlight support |
| |
Hi,
On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > > + EDP_DISPLAY_CTL_CAP_SIZE); > > > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > > drm_panel.c is in the latter, while drm_dp_dpcd_read() in > > drm_dp_helper.c is in the former. Please fix. > > Yeah, this was reported Friday and I posted a patch to try to fix it: > > https://lore.kernel.org/lkml/20210709152909.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/ > > I see Rajeev had some feedback on it. Once I've dug out of my weekend > email hole I'll take a look at plan to post a v2 ASAP.
Breadcrumbs: v2 of the fix is at:
https://lore.kernel.org/lkml/20210712075933.v2.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/
I'm hoping this looks OK so we can get this resolved before it trips too many people up.
-Doug
| |