lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 365/800] HID: surface-hid: Fix get-report request
    Date
    From: Maximilian Luz <luzmaximilian@gmail.com>

    [ Upstream commit 2b2bcc76e2ffbaff7e6ec1c62cb9c10881dc70cd ]

    Getting a report (e.g. feature report) from a device requires us to send
    a request indicating which report we want to retrieve and then waiting
    for the corresponding response containing that report. We already
    provide the response structure to the request call, but the request
    isn't marked as a request that expects a response. Thus the request
    returns before we receive the response and the response buffer indicates
    a zero length response due to that.

    This essentially means that the get-report calls are broken and will
    always indicate that a report of length zero has been read.

    Fix this by appropriately marking the request.

    Fixes: b05ff1002a5c ("HID: Add support for Surface Aggregator Module HID transport")
    Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/surface-hid/surface_hid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hid/surface-hid/surface_hid.c b/drivers/hid/surface-hid/surface_hid.c
    index 3477b31611ae..a3a70e4f3f6c 100644
    --- a/drivers/hid/surface-hid/surface_hid.c
    +++ b/drivers/hid/surface-hid/surface_hid.c
    @@ -143,7 +143,7 @@ static int ssam_hid_get_raw_report(struct surface_hid_device *shid, u8 rprt_id,
    rqst.target_id = shid->uid.target;
    rqst.instance_id = shid->uid.instance;
    rqst.command_id = SURFACE_HID_CID_GET_FEATURE_REPORT;
    - rqst.flags = 0;
    + rqst.flags = SSAM_REQUEST_HAS_RESPONSE;
    rqst.length = sizeof(rprt_id);
    rqst.payload = &rprt_id;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:2.108 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site