lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 563/800] Revert "ibmvnic: remove duplicate napi_schedule call in open function"
    Date
    From: Dany Madden <drt@linux.ibm.com>

    [ Upstream commit 2ca220f92878470c6ba03f9946e412323093cc94 ]

    This reverts commit 7c451f3ef676c805a4b77a743a01a5c21a250a73.

    When a vnic interface is taken down and then up, connectivity is not
    restored. We bisected it to this commit. Reverting this commit until
    we can fully investigate the issue/benefit of the change.

    Fixes: 7c451f3ef676 ("ibmvnic: remove duplicate napi_schedule call in open function")
    Reported-by: Cristobal Forno <cforno12@linux.ibm.com>
    Reported-by: Abdul Haleem <abdhalee@in.ibm.com>
    Signed-off-by: Dany Madden <drt@linux.ibm.com>
    Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/ibm/ibmvnic.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
    index 4b4eccc496a8..8b2f6eb8eb21 100644
    --- a/drivers/net/ethernet/ibm/ibmvnic.c
    +++ b/drivers/net/ethernet/ibm/ibmvnic.c
    @@ -1210,6 +1210,11 @@ static int __ibmvnic_open(struct net_device *netdev)

    netif_tx_start_all_queues(netdev);

    + if (prev_state == VNIC_CLOSED) {
    + for (i = 0; i < adapter->req_rx_queues; i++)
    + napi_schedule(&adapter->napi[i]);
    + }
    +
    adapter->state = VNIC_OPEN;
    return rc;
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:09    [W:4.046 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site