lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 488/800] mt76: mt7915: fix a signedness bug in mt7915_mcu_apply_tx_dpd()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 861fad474ec7638aeca46a508da4ea81612374b9 ]

    "idx" needs to be signed for the error handling to work.

    Fixes: 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
    index b3f14ff67c5a..764f25a828fa 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
    @@ -3440,8 +3440,9 @@ int mt7915_mcu_apply_tx_dpd(struct mt7915_phy *phy)
    {
    struct mt7915_dev *dev = phy->dev;
    struct cfg80211_chan_def *chandef = &phy->mt76->chandef;
    - u16 total = 2, idx, center_freq = chandef->center_freq1;
    + u16 total = 2, center_freq = chandef->center_freq1;
    u8 *cal = dev->cal, *eep = dev->mt76.eeprom.data;
    + int idx;

    if (!(eep[MT_EE_DO_PRE_CAL] & MT_EE_WIFI_CAL_DPD))
    return 0;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:43    [W:2.156 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site