lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 370/800] EDAC/igen6: fix core dependency
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 0a9ece9ba154dd6205709108180952c55e630833 ]

    igen6_edac needs mce_register()/unregister() functions,
    so it should depend on X86_MCE (or X86_MCE_INTEL).

    That change prevents these build errors:

    ld: drivers/edac/igen6_edac.o: in function `igen6_remove':
    igen6_edac.c:(.text+0x494): undefined reference to `mce_unregister_decode_chain'
    ld: drivers/edac/igen6_edac.o: in function `igen6_probe':
    igen6_edac.c:(.text+0xf5b): undefined reference to `mce_register_decode_chain'

    Fixes: 10590a9d4f23e ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: Tony Luck <tony.luck@intel.com>
    Link: https://lore.kernel.org/r/20210619160203.2026-1-rdunlap@infradead.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/edac/Kconfig | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
    index 1e836e320edd..91164c5f0757 100644
    --- a/drivers/edac/Kconfig
    +++ b/drivers/edac/Kconfig
    @@ -270,7 +270,8 @@ config EDAC_PND2

    config EDAC_IGEN6
    tristate "Intel client SoC Integrated MC"
    - depends on PCI && X86_64 && PCI_MMCONFIG && ARCH_HAVE_NMI_SAFE_CMPXCHG
    + depends on PCI && PCI_MMCONFIG && ARCH_HAVE_NMI_SAFE_CMPXCHG
    + depends on X64_64 && X86_MCE_INTEL
    help
    Support for error detection and correction on the Intel
    client SoC Integrated Memory Controller using In-Band ECC IP.
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:41    [W:2.438 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site