lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 156/800] crypto: qat - check return code of qat_hal_rd_rel_reg()
    Date
    From: Jack Xu <jack.xu@intel.com>

    [ Upstream commit 96b57229209490c8bca4335b01a426a96173dc56 ]

    Check the return code of the function qat_hal_rd_rel_reg() and return it
    to the caller.

    This is to fix the following warning when compiling the driver with
    clang scan-build:

    drivers/crypto/qat/qat_common/qat_hal.c:1436:2: warning: 6th function call argument is an uninitialized value

    Signed-off-by: Jack Xu <jack.xu@intel.com>
    Co-developed-by: Zhehui Xiang <zhehui.xiang@intel.com>
    Signed-off-by: Zhehui Xiang <zhehui.xiang@intel.com>
    Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/qat/qat_common/qat_hal.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
    index bd3028126cbe..069f51621f0e 100644
    --- a/drivers/crypto/qat/qat_common/qat_hal.c
    +++ b/drivers/crypto/qat/qat_common/qat_hal.c
    @@ -1417,7 +1417,11 @@ static int qat_hal_put_rel_wr_xfer(struct icp_qat_fw_loader_handle *handle,
    pr_err("QAT: bad xfrAddr=0x%x\n", xfr_addr);
    return -EINVAL;
    }
    - qat_hal_rd_rel_reg(handle, ae, ctx, ICP_GPB_REL, gprnum, &gprval);
    + status = qat_hal_rd_rel_reg(handle, ae, ctx, ICP_GPB_REL, gprnum, &gprval);
    + if (status) {
    + pr_err("QAT: failed to read register");
    + return status;
    + }
    gpr_addr = qat_hal_get_reg_addr(ICP_GPB_REL, gprnum);
    data16low = 0xffff & data;
    data16hi = 0xffff & (data >> 0x10);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:41    [W:3.346 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site