lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 001/800] Bluetooth: hci_qca: fix potential GPF
    Date
    From: Pavel Skripkin <paskripkin@gmail.com>

    commit 59f90f1351282ea2dbd0c59098fd9bb2634e920e upstream.

    In qca_power_shutdown() qcadev local variable is
    initialized by hu->serdev.dev private data, but
    hu->serdev can be NULL and there is a check for it.

    Since, qcadev is not used before

    if (!hu->serdev)
    return;

    we can move its initialization after this "if" to
    prevent GPF.

    Fixes: 5559904ccc08 ("Bluetooth: hci_qca: Add QCA Rome power off support to the qca_power_shutdown()")
    Cc: stable@vger.kernel.org # v5.6+
    Cc: Rocky Liao <rjliao@codeaurora.org>
    Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
    Reviewed-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/bluetooth/hci_qca.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/bluetooth/hci_qca.c
    +++ b/drivers/bluetooth/hci_qca.c
    @@ -1835,8 +1835,6 @@ static void qca_power_shutdown(struct hc
    unsigned long flags;
    enum qca_btsoc_type soc_type = qca_soc_type(hu);

    - qcadev = serdev_device_get_drvdata(hu->serdev);
    -
    /* From this point we go into power off state. But serial port is
    * still open, stop queueing the IBS data and flush all the buffered
    * data in skb's.
    @@ -1852,6 +1850,8 @@ static void qca_power_shutdown(struct hc
    if (!hu->serdev)
    return;

    + qcadev = serdev_device_get_drvdata(hu->serdev);
    +
    if (qca_is_wcn399x(soc_type)) {
    host_set_baudrate(hu, 2400);
    qca_send_power_pulse(hu, false);

    \
     
     \ /
      Last update: 2021-07-12 10:41    [W:4.021 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site