lkml.org 
[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver

> I just noticed this now, but this function even tries to send data
> partially, which isn't right. If the caller (i2c device's driver)
> calls this for 5 struct i2c_msg instances, then all 5 need to get
> through or none.. where as we try to send as many as possible here.
>
> This looks broken to me. Rather return an error value here on success,
> or make it complete failure.
>
> Though to be fair I see i2c-core also returns number of messages
> processed from i2c_transfer().
>
> Wolfram, what's expected here ? Shouldn't all message transfer or
> none?

Well, on a physical bus, it can simply happen that after message 3 of 5,
the bus is stalled, so we need to bail out.

Again, I am missing details of a virtqueue, but I'd think it is
different. If adding to the queue fails, then it probably make sense to
drop the whole transfer.

Of course, it can later happen on the physical bus of the host, though,
that the bus is stalled after message 3 of 5, and I2C_RDWR will bail
out.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-07-01 21:25    [W:0.132 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site