lkml.org 
[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not PID_MAX_DEFAULT
Hi Steven,

On Thu, Jul 01, 2021 at 02:12:21PM -0400, Steven Rostedt wrote:
> On Thu, 1 Jul 2021 10:24:07 -0700
> Paul Burton <paulburton@google.com> wrote:
>
> > +static int *trace_find_tgid_ptr(int pid)
> > +{
> > + // Pairs with the smp_store_release in set_tracer_flag() to ensure that
> > + // if we observe a non-NULL tgid_map then we also observe the correct
> > + // tgid_map_max.
>
> BTW, it's against the Linux kernel coding style to use // for comments.
>
> I can take this patch, but I need to change this to:
>
> /*
> * Pairs with the smp_store_release in set_tracer_flag() to ensure that
> * if we observe a non-NULL tgid_map then we also observe the correct
> * tgid_map_max.
> */
>
> Same with the other comments. Please follow coding style that can be
> found in:
>
> Documentation/process/coding-style.rst
>
> And see section 8 on Commenting.

Yeah, sorry about that - I should know better having been a maintainer
in a former life...

Just to confirm - are you happy to fix those up when applying or should
I send a v3?

Thanks,
Paul

\
 
 \ /
  Last update: 2021-07-01 20:17    [W:0.079 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site