lkml.org 
[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup
From
Date
On Thu, 2021-07-01 at 11:31 +0200, Uwe Kleine-König wrote:
> Hello,
>
> On 7/1/21 2:40 AM, Dennis Gilmore wrote:
> > Without the usbdrd_dwc3_1 node defined u-boot will throw an error
> > and
> > reset the system.
>
> I wonder if this should better be fixed in u-boot then?!
>
> > All other rk3399 systems use this format
>
> This is true for the dwc nodes, however for the usb2 nodes there are
> several that use this idiom (and even repeat the label name), see for
> example the &u2phy0 node in
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .
>

looking at that file is where I got the idea to set it up as I have
proposed, it follows the format I have submitted

Dennis

> In my eyes it's a bit ugly to have the two nodes as separate entities
> and on the same indentation level in the machine dts given that one
> is
> the parent of the other and enabling USB needs both status settings.
>
> Best regards
> Uwe
>


\
 
 \ /
  Last update: 2021-07-01 15:01    [W:0.055 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site