lkml.org 
[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] tools: bpftool: close va_list 'ap' by va_end()
Date
From: gushengxian <gushengxian@yulong.com>

va_list 'ap' was opened but not closed by va_end(). It should be
closed by va_end() before return.

Signed-off-by: gushengxian <gushengxian@yulong.com>
---
tools/bpf/bpftool/jit_disasm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index e7e7eee9f172..3c85fd1f00cb 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -45,8 +45,10 @@ static int fprintf_json(void *out, const char *fmt, ...)
char *s;

va_start(ap, fmt);
- if (vasprintf(&s, fmt, ap) < 0)
+ if (vasprintf(&s, fmt, ap) < 0) {
+ va_end(ap);
return -1;
+ }
va_end(ap);

if (!oper_count) {
--
2.25.1
\
 
 \ /
  Last update: 2021-07-01 14:02    [W:0.044 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site