[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tty: n_gsm: delete DISC command frame as requester
Hi Zhenguo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: tty-testing
config: x86_64-randconfig-a015-20210630 (attached as .config)
compiler: clang version 13.0.0 ( e7e71e9454ed76c1b3d8140170b5333c28bef1be)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git remote add linux-review
git fetch --no-tags linux-review Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-110614
git checkout 0ac8d1e74492d1765c356f163a7b793a74155fc6
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

>> drivers/tty/n_gsm.c:3031:6: error: use of undeclared identifier 'gsm'
if (gsm->initiator)
drivers/tty/n_gsm.c:3046:6: error: use of undeclared identifier 'gsm'
if (gsm->initiator)
2 errors generated.

vim +/gsm +3031 drivers/tty/n_gsm.c

3018 static void gsmtty_close(struct tty_struct *tty, struct file *filp)
3019 {
3020 struct gsm_dlci *dlci = tty->driver_data;
3022 if (dlci == NULL)
3023 return;
3024 if (dlci->state == DLCI_CLOSED)
3025 return;
3026 mutex_lock(&dlci->mutex);
3027 gsm_destroy_network(dlci);
3028 mutex_unlock(&dlci->mutex);
3029 if (tty_port_close_start(&dlci->port, tty, filp) == 0)
3030 return;
> 3031 if (gsm->initiator)
3032 gsm_dlci_begin_close(dlci);
3033 if (tty_port_initialized(&dlci->port) && C_HUPCL(tty))
3034 tty_port_lower_dtr_rts(&dlci->port);
3035 tty_port_close_end(&dlci->port, tty);
3036 tty_port_tty_set(&dlci->port, NULL);
3037 return;
3038 }

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2021-07-01 13:03    [W:0.030 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site