Messages in this thread | | | Subject | Re: [PATCH 1/1] lib: remove leading spaces before tabs | From | "Leizhen (ThunderTown)" <> | Date | Wed, 9 Jun 2021 14:21:20 +0800 |
| |
On 2021/6/9 13:15, Leizhen (ThunderTown) wrote: > > > On 2021/6/9 0:03, Joe Perches wrote: >> On Tue, 2021-06-08 at 17:00 +0800, Leizhen (ThunderTown) wrote: >>> On 2021/6/8 16:44, Andy Shevchenko wrote: >>>> On Tue, Jun 8, 2021 at 10:14 AM Zhen Lei <thunder.leizhen@huawei.com> wrote: >>>>> >>>>> 1) Run the following command to find and remove the leading spaces before >>>>> tabs: >>>>> find lib/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/' >>>> >>>> Hint for the future, try to use what Git provides, for example `git >>>> ls-files -- lib/`. >>> >>> Okay, thanks. I learned a new trick. >> >> Perhaps another 'trick'. >> >> checkpatch has SPACE_BEFORE_TAB which does this for any spaces before >> a tab, not just at the start of lines. But as you've no doubt seen, >> many maintainers do not care for this sort of whitespace only change >> so it's best to do this sparingly or only in drivers/staging/ paths. > > I've always thought of kernel, mm, and lib as the core modules of Linux, > and they serve as showcases for successors. I'm not interested in making > coding style improvements unless it's a work-related driver that I > usually read. > >> >> For instance: >> >> $ git diff --stat lib >> $ git ls-files lib/ | \ >> xargs ./scripts/checkpatch.pl --types=SPACE_BEFORE_TAB --fix-inplace
I just tried it. It's too slow.
The command I used earlier, removing the line start match "^", can also do that.
git ls-files lib/ | xargs sed -r -i 's/[ ]+\t/\t/'
> > Wow, It's so powerful. Thanks. > >> >> >> >> . >>
| |