Messages in this thread | | | Subject | Re: [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support" | From | Sander Vanheule <> | Date | Wed, 09 Jun 2021 14:42:06 +0200 |
| |
On Wed, 2021-06-09 at 13:24 +0100, Mark Brown wrote: > On Wed, Jun 09, 2021 at 01:46:05PM +0200, Sander Vanheule wrote: > > This reverts commit f083be9db060fbac09123d80bdffb2c001ac0e2b. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone.
I had grepped the commit log for other reverting patches, which also appear to use this style, but I didn't check the regmap-specific ones.
> > There are currently no (planned) regmap users for C45 register access. > > Remove support for now, to reduce dead code. > > This then creates a bootstrapping issue for anyone who does need it - I > can't see any way in which this causes problems or gets in the way?
If you would rather keep this, I should modify the other patch (regmap: mdio: Reject invalid clause-22 addresses) to also cover C45 addresses. Furthermore, there's an issue with a pointer const-ness in __regmap_init_mdio that needs to be fixed if this code is staying.
I'll submit a v2 that fixes __regmap_init_mdio, and also applies the address checks to C45 access.
Best, Sander
| |