Messages in this thread | | | Subject | Re: [PATCH] NULL check value returned by alloc_skb | From | Marcel Holtmann <> | Date | Wed, 9 Jun 2021 14:20:48 +0200 |
| |
Hi Dhiraj,
> Return error ENOMEM if alloc_skb() failed. > > Signed-off-by: Dhiraj Shah <find.dhiraj@gmail.com> > --- > drivers/bluetooth/virtio_bt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c > index c804db7e90f8..5f82574236c0 100644 > --- a/drivers/bluetooth/virtio_bt.c > +++ b/drivers/bluetooth/virtio_bt.c > @@ -34,6 +34,8 @@ static int virtbt_add_inbuf(struct virtio_bluetooth *vbt) > int err; > > skb = alloc_skb(1000, GFP_KERNEL); > + if (!skb) > + return -ENOMEM; > sg_init_one(sg, skb->data, 1000); > > err = virtqueue_add_inbuf(vq, sg, 1, skb, GFP_KERNEL);
a similar patch is already upstream in bluetooth-next.
Regards
Marcel
| |