lkml.org 
[lkml]   [2021]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support
    Date
    diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index 6e6a0252dc15..b1128b0ce486 100644
    --- a/drivers/scsi/ufs/ufshpb.h
    +++ b/drivers/scsi/ufs/ufshpb.h
    @@ -30,19 +30,29 @@
    #define PINNED_NOT_SET U32_MAX

    /* hpb support chunk size */
    -#define HPB_MULTI_CHUNK_HIGH 1
    +#define HPB_LEGACY_CHUNK_HIGH 1
    +#define HPB_MULTI_CHUNK_LOW 7
    +#define HPB_MULTI_CHUNK_HIGH 128

    According to the JEDEC spec, bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD can be set from 4kb to 1024kb.
    The transfer length should be provided up to 1020kb or 1024kb.
    Why did you set HPB_MULTI_CHUNK_HIGH to 128?
    It can sends the hpb command up to 512kb.
    This doesn't seem to match the specs.

    Thanks
    Yohan.
    \
     
     \ /
      Last update: 2021-06-10 04:10    [W:2.587 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site