Messages in this thread Patch in this message | | | From | Baokun Li <> | Subject | [PATCH -next v2] drm/nouveau/fifo: use list_move instead of list_del/list_add in base.c | Date | Wed, 9 Jun 2021 15:05:34 +0800 |
| |
Using list_move() instead of list_del() + list_add() in base.c.
Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Baokun Li <libaokun1@huawei.com> --- V1->V2: CC mailist
drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c index 2ed4ff05d207..1802ac78b78f 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c @@ -79,8 +79,7 @@ nvkm_fifo_chan_inst_locked(struct nvkm_fifo *fifo, u64 inst) struct nvkm_fifo_chan *chan; list_for_each_entry(chan, &fifo->chan, head) { if (chan->inst->addr == inst) { - list_del(&chan->head); - list_add(&chan->head, &fifo->chan); + list_move(&chan->head, &fifo->chan); return chan; } } @@ -109,8 +108,7 @@ nvkm_fifo_chan_chid(struct nvkm_fifo *fifo, int chid, unsigned long *rflags) spin_lock_irqsave(&fifo->lock, flags); list_for_each_entry(chan, &fifo->chan, head) { if (chan->chid == chid) { - list_del(&chan->head); - list_add(&chan->head, &fifo->chan); + list_move(&chan->head, &fifo->chan); *rflags = flags; return chan; }
| |