Messages in this thread | | | Date | Wed, 9 Jun 2021 11:43:31 -0700 | From | Jaegeuk Kim <> | Subject | Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit |
| |
On 06/08, Chao Yu wrote: > On 2021/6/8 0:56, Jaegeuk Kim wrote: > > On 06/06, Chao Yu wrote: > > > On 2021/5/26 4:49, Jaegeuk Kim wrote: > > > > Once we release compressed blocks, we used to set IMMUTABLE bit. But it turned > > > > out it disallows every fs operations which we don't need for compression. > > > > > > > > Let's just prevent writing data only. > > > > > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > > > > > Reviewed-by: Chao Yu <yuchao0@huawei.com> > > > > > > BTW, we need to expose .i_inline field to userspace since there is no > > > way to check status of inode whether it has released blocks? > > > > Need to add some in F2FS_IOC_GET_COMPRESS_OPTION? > > We should not change this interface, in order to keep its compatibility for > userspace usage. How about adding it in F2FS_IOC_GET_COMPRESS_OPTION_EX?
Hmm, or need to add it in getflags?
> > Thanks, > > > > > > > > > Thanks,
| |