Messages in this thread | | | From | Ulf Hansson <> | Date | Tue, 8 Jun 2021 14:52:33 +0200 | Subject | Re: [“PATCH” 2/2] phy: intel: Fix for warnings d ue to EMMC clock 175Mhz change in FIP |
| |
On Thu, 3 Jun 2021 at 20:22, <rashmi.a@intel.com> wrote: > > From: Rashmi A <rashmi.a@intel.com> > > Since the EMMC clock was changed from 200Mhz to 175Mhz in FIP, > there were some warnings introduced, as the frequency values > being checked was still wrt 200Mhz in code. Hence, the frequency > checks are now updated based on the current 175Mhz EMMC clock changed > in FIP. > > Spamming kernel log msg: > "phy phy-20290000.mmc_phy.2: Unsupported rate: 43750000" > > Signed-off-by: Rashmi A <rashmi.a@intel.com> > Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
I guess $subject patch should be queued together with patch1/2 (via the mmc tree?), no?
Vinod, Kishion, if that's okay I need an ack from you to pick it up.
Kind regards Uffe
> --- > drivers/phy/intel/phy-intel-keembay-emmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/intel/phy-intel-keembay-emmc.c b/drivers/phy/intel/phy-intel-keembay-emmc.c > index eb7c635ed89a..0eb11ac7c2e2 100644 > --- a/drivers/phy/intel/phy-intel-keembay-emmc.c > +++ b/drivers/phy/intel/phy-intel-keembay-emmc.c > @@ -95,7 +95,8 @@ static int keembay_emmc_phy_power(struct phy *phy, bool on_off) > else > freqsel = 0x0; > > - if (mhz < 50 || mhz > 200) > + /* Check for EMMC clock rate*/ > + if (mhz > 175) > dev_warn(&phy->dev, "Unsupported rate: %d MHz\n", mhz); > > /* > -- > 2.17.1 >
| |