lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 156/161] ARM: OMAP1: isp1301-omap: Add missing gpiod_add_lookup_table function
    Date
    From: Maciej Falkowski <maciej.falkowski9@gmail.com>

    commit 7c302314f37b44595f180198fca5ca646bce4a5f upstream.

    The gpiod table was added without any usage making it unused
    as reported by Clang compilation from omap1_defconfig on linux-next:

    arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable
    'isp1301_gpiod_table' [-Wunused-variable]
    static struct gpiod_lookup_table isp1301_gpiod_table = {
    ^
    1 warning generated.

    The patch adds the missing gpiod_add_lookup_table() function.

    Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
    Fixes: f3ef38160e3d ("usb: isp1301-omap: Convert to use GPIO descriptors")
    Link: https://github.com/ClangBuiltLinux/linux/issues/1325
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm/mach-omap1/board-h2.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/arch/arm/mach-omap1/board-h2.c
    +++ b/arch/arm/mach-omap1/board-h2.c
    @@ -320,7 +320,7 @@ static int tps_setup(struct i2c_client *
    {
    if (!IS_BUILTIN(CONFIG_TPS65010))
    return -ENOSYS;
    -
    +
    tps65010_config_vregs1(TPS_LDO2_ENABLE | TPS_VLDO2_3_0V |
    TPS_LDO1_ENABLE | TPS_VLDO1_3_0V);

    @@ -394,6 +394,8 @@ static void __init h2_init(void)
    BUG_ON(gpio_request(H2_NAND_RB_GPIO_PIN, "NAND ready") < 0);
    gpio_direction_input(H2_NAND_RB_GPIO_PIN);

    + gpiod_add_lookup_table(&isp1301_gpiod_table);
    +
    omap_cfg_reg(L3_1610_FLASH_CS2B_OE);
    omap_cfg_reg(M8_1610_FLASH_CS2B_WE);


    \
     
     \ /
      Last update: 2021-06-08 21:35    [W:4.258 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site