lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 047/161] igb: add correct exception tracing for XDP
    Date
    From: Magnus Karlsson <magnus.karlsson@intel.com>

    [ Upstream commit 74431c40b9c5fa673fff83ec157a76a69efd5c72 ]

    Add missing exception tracing to XDP when a number of different
    errors can occur. The support was only partial. Several errors
    where not logged which would confuse the user quite a lot not
    knowing where and why the packets disappeared.

    Fixes: 9cbc948b5a20 ("igb: add XDP support")
    Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
    Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
    Tested-by: Vishakha Jambekar <vishakha.jambekar@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++----
    1 file changed, 6 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
    index a41b85f1fc94..caa8929289ae 100644
    --- a/drivers/net/ethernet/intel/igb/igb_main.c
    +++ b/drivers/net/ethernet/intel/igb/igb_main.c
    @@ -8395,18 +8395,20 @@ static struct sk_buff *igb_run_xdp(struct igb_adapter *adapter,
    break;
    case XDP_TX:
    result = igb_xdp_xmit_back(adapter, xdp);
    + if (result == IGB_XDP_CONSUMED)
    + goto out_failure;
    break;
    case XDP_REDIRECT:
    err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog);
    - if (!err)
    - result = IGB_XDP_REDIR;
    - else
    - result = IGB_XDP_CONSUMED;
    + if (err)
    + goto out_failure;
    + result = IGB_XDP_REDIR;
    break;
    default:
    bpf_warn_invalid_xdp_action(act);
    fallthrough;
    case XDP_ABORTED:
    +out_failure:
    trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
    fallthrough;
    case XDP_DROP:
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 21:32    [W:4.117 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site