lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 07/78] efi: Allow EFI_MEMORY_XP and EFI_MEMORY_RO both to be cleared
    Date
    From: Heiner Kallweit <hkallweit1@gmail.com>

    [ Upstream commit 45add3cc99feaaf57d4b6f01d52d532c16a1caee ]

    UEFI spec 2.9, p.108, table 4-1 lists the scenario that both attributes
    are cleared with the description "No memory access protection is
    possible for Entry". So we can have valid entries where both attributes
    are cleared, so remove the check.

    Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
    Fixes: 10f0d2f577053 ("efi: Implement generic support for the Memory Attributes table")
    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/efi/memattr.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/firmware/efi/memattr.c b/drivers/firmware/efi/memattr.c
    index 58452fde92cc..5d343dc8e535 100644
    --- a/drivers/firmware/efi/memattr.c
    +++ b/drivers/firmware/efi/memattr.c
    @@ -66,11 +66,6 @@ static bool entry_is_valid(const efi_memory_desc_t *in, efi_memory_desc_t *out)
    return false;
    }

    - if (!(in->attribute & (EFI_MEMORY_RO | EFI_MEMORY_XP))) {
    - pr_warn("Entry attributes invalid: RO and XP bits both cleared\n");
    - return false;
    - }
    -
    if (PAGE_SIZE > EFI_PAGE_SIZE &&
    (!PAGE_ALIGNED(in->phys_addr) ||
    !PAGE_ALIGNED(in->num_pages << EFI_PAGE_SHIFT))) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 20:50    [W:4.128 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site