lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 05/78] hwmon: (dell-smm-hwmon) Fix index values
    Date
    From: Armin Wolf <W_Armin@gmx.de>

    [ Upstream commit 35d470b5fbc9f82feb77b56bb0d5d0b5cd73e9da ]

    When support for up to 10 temp sensors and for disabling automatic BIOS
    fan control was added, noone updated the index values used for
    disallowing fan support and fan type calls.
    Fix those values.

    Signed-off-by: Armin Wolf <W_Armin@gmx.de>
    Reviewed-by: Pali Rohár <pali@kernel.org>
    Link: https://lore.kernel.org/r/20210513154546.12430-1-W_Armin@gmx.de
    Fixes: 1bb46a20e73b ("hwmon: (dell-smm) Support up to 10 temp sensors")
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/dell-smm-hwmon.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
    index 4212d022d253..35c00420d855 100644
    --- a/drivers/hwmon/dell-smm-hwmon.c
    +++ b/drivers/hwmon/dell-smm-hwmon.c
    @@ -792,10 +792,10 @@ static struct attribute *i8k_attrs[] = {
    static umode_t i8k_is_visible(struct kobject *kobj, struct attribute *attr,
    int index)
    {
    - if (disallow_fan_support && index >= 8)
    + if (disallow_fan_support && index >= 20)
    return 0;
    if (disallow_fan_type_call &&
    - (index == 9 || index == 12 || index == 15))
    + (index == 21 || index == 25 || index == 28))
    return 0;
    if (index >= 0 && index <= 1 &&
    !(i8k_hwmon_flags & I8K_HWMON_HAVE_TEMP1))
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 20:49    [W:4.318 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site