lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] thermal: devfreq_cooling: Fix kernel-doc
    On Tue, Jun 8, 2021 at 2:46 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
    >
    > Fix function name in devfreq_cooling.c kernel-doc comment
    > to remove a warning found by clang(make W=1 LLVM=1).
    >
    > drivers/thermal/devfreq_cooling.c:479: warning: expecting prototype for
    > devfreq_cooling_em_register_power(). Prototype was for
    > devfreq_cooling_em_register() instead.
    >
    > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

    That compiler warning doesn't come from kernel-doc. Your diff looks
    good (the comment was wrong), but the commit message is curious.

    Usually that warning is from when the function prototype does not
    exist for a function with extern linkage. It looks like that's always
    provided though in include/linux/devfreq_cooling.h. Can you share a
    link to the original report?

    > ---
    > drivers/thermal/devfreq_cooling.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
    > index 3a788ac..5a86cff 100644
    > --- a/drivers/thermal/devfreq_cooling.c
    > +++ b/drivers/thermal/devfreq_cooling.c
    > @@ -458,7 +458,7 @@ struct thermal_cooling_device *devfreq_cooling_register(struct devfreq *df)
    > EXPORT_SYMBOL_GPL(devfreq_cooling_register);
    >
    > /**
    > - * devfreq_cooling_em_register_power() - Register devfreq cooling device with
    > + * devfreq_cooling_em_register() - Register devfreq cooling device with
    > * power information and automatically register Energy Model (EM)
    > * @df: Pointer to devfreq device.
    > * @dfc_power: Pointer to devfreq_cooling_power.
    > --
    > 1.8.3.1
    >


    --
    Thanks,
    ~Nick Desaulniers

    \
     
     \ /
      Last update: 2021-06-08 20:45    [W:3.585 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site