lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 14/58] ieee802154: fix error return code in ieee802154_add_iface()
    Date
    From: Zhen Lei <thunder.leizhen@huawei.com>

    [ Upstream commit 79c6b8ed30e54b401c873dbad2511f2a1c525fd5 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: be51da0f3e34 ("ieee802154: Stop using NLA_PUT*().")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    Link: https://lore.kernel.org/r/20210508062517.2574-1-thunder.leizhen@huawei.com
    Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ieee802154/nl-phy.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/net/ieee802154/nl-phy.c b/net/ieee802154/nl-phy.c
    index b231e40f006a..ca1dd9ff07ab 100644
    --- a/net/ieee802154/nl-phy.c
    +++ b/net/ieee802154/nl-phy.c
    @@ -249,8 +249,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct genl_info *info)
    }

    if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) ||
    - nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name))
    + nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) {
    + rc = -EMSGSIZE;
    goto nla_put_failure;
    + }
    dev_put(dev);

    wpan_phy_put(phy);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 20:39    [W:4.134 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site