lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vlan: Avoid crashing the kernel
On Sun,  6 Jun 2021 20:08:39 -0700
13145886936@163.com wrote:

> From: gushengxian <gushengxian@yulong.com>
>
> Avoid crashing the kernel, try using WARN_ON & recovery code
> rather than BUG() or BUG_ON().
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> net/8021q/vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index 4cdf8416869d..6e784fd8795b 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -97,7 +97,7 @@ void unregister_vlan_dev(struct net_device *dev, struct list_head *head)
> ASSERT_RTNL();
>
> vlan_info = rtnl_dereference(real_dev->vlan_info);
> - BUG_ON(!vlan_info);
> + WARN_ON(!vlan_info);
>
> grp = &vlan_info->grp;

NACK

You change turns bug on into warning and crash from null pointer dereference.

\
 
 \ /
  Last update: 2021-06-07 17:34    [W:0.094 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site