lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 4/6] reset: Add Delta TN48M CPLD reset controller
On Mon, Jun 7, 2021 at 11:23 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> Hi Robert,
>
> On Wed, 2021-06-02 at 14:24 +0200, Robert Marko wrote:
> > Delta TN48M CPLD exposes resets for the following:
> > * 88F7040 SoC
> > * 88F6820 SoC
> > * 98DX3265 switch MAC-s
> > * 88E1680 PHY-s
> > * 88E1512 PHY
> > * PoE PSE controller
> >
> > Controller supports only self clearing resets.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> > drivers/reset/Kconfig | 9 +++
> > drivers/reset/Makefile | 1 +
> > drivers/reset/reset-tn48m.c | 128 ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 138 insertions(+)
> > create mode 100644 drivers/reset/reset-tn48m.c
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 4171c6f76385..14e179cda58c 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -237,6 +237,15 @@ config RESET_TI_SYSCON
> > you wish to use the reset framework for such memory-mapped devices,
> > say Y here. Otherwise, say N.
> >
> > +config RESET_TN48M_CPLD
> > + tristate "Delta Networks TN48M switch CPLD reset controller"
> > + depends on MFD_TN48M_CPLD
>
> Let's make this
>
> depends on MFD_TN48M_CPLD || COMPILE_TEST
> default MFD_TN48M_CPLD

Sure, I will change that and send a v5.
>
> unless there is a reason not to enable the reset driver by default when
> the MFD driver is activated.

No, it's just a habit of making everything optional.

Regards,
Robert
>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> regards
> Philipp



--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

\
 
 \ /
  Last update: 2021-06-07 12:42    [W:0.058 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site