Messages in this thread | | | Date | Mon, 7 Jun 2021 06:48:49 +0200 | From | Greg KH <> | Subject | Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG |
| |
On Mon, Jun 07, 2021 at 02:34:36AM +0000, Ricky WU wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Friday, June 4, 2021 10:48 PM > > To: Ricky WU > > Cc: arnd@arndb.de; bhelgaas@google.com; rui_feng@realsil.com.cn; > > ulf.hansson@linaro.org; vaibhavgupta40@gmail.com; > > yang.lee@linux.alibaba.com; keitasuzuki.park@sslab.ics.keio.ac.jp; > > chris.chiu@canonical.com; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and > > MODE_CFG > > > > On Fri, Jun 04, 2021 at 10:42:11PM +0800, ricky_wu@realtek.com wrote: > > > From: Ricky Wu <ricky_wu@realtek.com> > > > > > > Divide Realtek Card Reader Group into two different modes > > > ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250 Change back to use > > > original way to control aspm > > > > What is "aspm"? > > > Active State Power Management (ASPM)
Great, please spell it out in the changelog text when you resubmit this.
> rtsx_comm_set_aspm: ASPM control function for our driver > to make sure not enter power saving in process of init and card_detcct
Ok, can you please say all of this in the changelog text?
> > > +#define ASPM_MODE_CFG 0x01 > > > +#define ASPM_MODE_REG 0x02 > > > + u8 aspm_mode; > > > > Why not use an enum? > > > > It is ok, we can have a V2 to use enum
Please do so.
thanks,
greg k-h
| |