lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/4] lazy tlb: introduce lazy mm refcount helper functions
On Tue, 08 Jun 2021 11:39:56 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:

> > Looks like a functional change. What's happening here?
>
> That's kthread_use_mm being clever about the lazy tlb mm. If it happened
> that the kthread had inherited a the lazy tlb mm that happens to be the
> one we want to use here, then we already have a refcount to it via the
> lazy tlb ref.
>
> So then it doesn't have to touch the refcount, but rather just converts
> it from the lazy tlb ref to the returned reference. If the lazy tlb mm
> doesn't get a reference, we can't do that.

Please cover this in the changelog and perhaps a code comment.

\
 
 \ /
  Last update: 2021-06-08 03:50    [W:0.717 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site