lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH v2 10/11] riscv: soc: Add Allwinner SoC kconfig option
    On Mon, Jun 7, 2021 at 9:20 AM Maxime Ripard <maxime@cerno.tech> wrote:
    > On Sun, Jun 06, 2021 at 09:04:08AM +0000, guoren@kernel.org wrote:

    > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
    > > index ed96376..055fb3e 100644
    > > --- a/arch/riscv/Kconfig.socs
    > > +++ b/arch/riscv/Kconfig.socs
    > > @@ -69,4 +69,16 @@ config SOC_CANAAN_K210_DTB_SOURCE
    > >
    > > endif
    > >
    > > +config SOC_SUNXI
    > > + bool "Allwinner SoCs"
    > > + depends on MMU
    > > + select DWMAC_GENERIC
    > > + select SERIAL_8250
    > > + select SERIAL_8250_CONSOLE
    > > + select SERIAL_8250_DW
    > > + select SIFIVE_PLIC
    > > + select STMMAC_ETH
    > > + help
    > > + This enables support for Allwinner SoC platforms like the D1.
    > > +
    >
    > We probably don't want to select DWMAC, STMMAC_ETH and the 8250 options,
    > looks good otherwise.

    Correct: those subsystems may be completely disabled, which would lead to a
    build failure, and a platform should not force-enable drivers or
    subsystems unless
    those are build time dependencies.

    Arnd

    \
     
     \ /
      Last update: 2021-06-07 09:31    [W:2.951 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site