lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver
On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote:
> Hi Matthias,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on next-20210604]
> [also build test WARNING on v5.13-rc4]
> [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5.13-rc2]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213
> base: ccc252d2e818f6a479441119ad453c3ce7c7c461
> config: arc-allyesconfig (attached as .config)
> compiler: arceb-elf-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/7107f99a12058b7147342c6f763d026102bd6606
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213
> git checkout 7107f99a12058b7147342c6f763d026102bd6606
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous prototype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes]
> 400 | void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_head *pdev_list)
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous prototype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes]
> 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~

Oh, I wasn't aware that prototypes are required for public functions.

To avoid too much version churn I'll wait a bit for further comments before
sending a v12 with the prototypes.

\
 
 \ /
  Last update: 2021-06-07 19:53    [W:0.084 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site