Messages in this thread | | | Date | Sat, 5 Jun 2021 21:10:19 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 4/7] Input: cy8ctmg110_ts - let I2C core configure wake interrupt |
| |
On Fri, Jun 04, 2021 at 09:32:53AM +0200, Linus Walleij wrote: > On Thu, Jun 3, 2021 at 6:37 AM Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > > I2C core already configures interrupt as wakeup source when device is > > registered using I2C_CLIENT_WAKE flag, so let's rely on it instead of > > configuring it ourselves. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > I wonder how many bugs of this deep semantic type we have in the kernel :/
I do not think this is necessarily a bug, it just shows age of the driver that was written before I2C core was doing this set up for us.
Thanks.
-- Dmitry
| |