lkml.org 
[lkml]   [2021]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5.10 235/252] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static
    On Sat, Jun 05, 2021 at 03:42:22PM +0200, Pavel Machek wrote:
    > Hi!
    >
    > > From: kernel test robot <lkp@intel.com>
    > >
    > > [ Upstream commit 2b899f31f1a6db2db4608bac2ac04fe2c4ad89eb ]
    > >
    > > sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
    > >
    > > Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages")
    > > Reported-by: kernel test robot <lkp@intel.com>
    > > Signed-off-by: kernel test robot <lkp@intel.com>
    > > Link: https://lore.kernel.org/r/20210522180900.GA83915@f59a3af2f1d9
    > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
    > > Signed-off-by: Sasha Levin <sashal@kernel.org>
    >
    > We normally require real, legal names for commit authors and
    > signoffs. I guess it is a bit late now, but... we don't take
    > pseudonyms so we should not take robots.

    We have long-taken patches from the kernel test robot, this is not
    something new.

    \
     
     \ /
      Last update: 2021-06-05 19:07    [W:4.283 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site