lkml.org 
[lkml]   [2021]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 16/16] objtool,x86: Rewrite retpoline thunk calls
    On Fri, Jun 04, 2021 at 04:50:46PM -0700, Fangrui Song wrote:
    > On 2021-06-04, 'Nick Desaulniers' via Clang Built Linux wrote:

    > > is producing the linker error:
    > >
    > > ld.lld: error: drivers/gpu/drm/amd/amdgpu/amdgpu.lto.o:
    > > SHT_SYMTAB_SHNDX has 79581 entries, but the symbol table associated
    > > has 79582
    > >
    > > Readelf having issues with the output:
    > > $ readelf -s amdgpu.lto.o.orig
    > > <works fine>
    > > $ readelf -s amdgpu.lto.o
    > > readelf: Error: Reading 73014451695 bytes extends past end of file for
    > > string table
    > > $ llvm-readelf -s amdgpu.lto.o
    > > llvm-readelf: error: 'amdgpu.lto.o': unable to continue dumping, the
    > > file is corrupt: section table goes past the end of file
    > >

    > tools/objtool/elf.c:elf_add_symbol may not update .symtab_shndx .
    > Speaking of llvm-objcopy, it finalizes the content of .symtab_shndx when .symtab
    > is finalized. objtool may want to adopt a similar approach.
    >
    > read_symbols searches for the section ".symtab_shndx". It'd be better to
    > use the section type SHT_SYMTAB_SHNDX.

    I think you've absolutely nailed it; but would you have more information
    or a code reference to what you're speaking about? My complete ELF
    and libelf knowledge is very limited and as demonstrated here, I'm not
    at all sure how all that extended index stuff is supposed to work.

    \
     
     \ /
      Last update: 2021-06-05 12:40    [W:3.632 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site