Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 4 Jun 2021 23:44:39 +0200 | Subject | Re: [PATCH 1/2] drm/vc4: hdmi: Fix error path of hpd-gpios |
| |
On Mon, May 24, 2021 at 3:19 PM Maxime Ripard <maxime@cerno.tech> wrote:
> If the of_get_named_gpio_flags call fails in vc4_hdmi_bind, we jump to > the err_unprepare_hsm label. That label will then call > pm_runtime_disable and put_device on the DDC device. > > We just retrieved the DDC device, so the latter is definitely justified. > However at that point we still haven't called pm_runtime_enable, so the > call to pm_runtime_disable is not supposed to be there. > > Fixes: 10ee275cb12f ("drm/vc4: prepare for CEC support") > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |