lkml.org 
[lkml]   [2021]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/7] platform/surface: aggregator: Allow enabling of events without notifiers
From
Date
On 6/4/21 10:13 PM, Hans de Goede wrote:
> Hi,
>
> On 6/4/21 3:47 PM, Maximilian Luz wrote:

[...]

>> +static int ssam_nf_refcount_enable(struct ssam_controller *ctrl,
>> + struct ssam_nf_refcount_entry *entry, u8 flags)
>> +{
>> + const struct ssam_event_registry reg = entry->key.reg;
>> + const struct ssam_event_id id = entry->key.id;
>> + struct ssam_nf *nf = &ctrl->cplt.event.notif;
>> + int status;
>> +
>> + lockdep_assert_held(&nf->lock);
>> +
>> + ssam_dbg(ctrl, "enabling event (reg: %#04x, tc: %#04x, iid: %#04x, rc: %d)\n",
>> + reg.target_category, id.target_category, id.instance, entry->refcount);
>> +
>> + if (entry->refcount == 1) {
>> + status = ssam_ssh_event_enable(ctrl, reg, id, flags);
>> + if (status)
>> + return status;
>> +
>> + entry->flags = flags;
>> +
>> + } else if (entry->flags != flags) {
>> + ssam_warn(ctrl,
>> + "inconsistent flags when enabling event: got %#04x, expected %#04x (reg: %#04x, tc: %#04x, iid: %#04x)\n",
>> + flags, entry->flags, reg.target_category, id.target_category,
>> + id.instance);
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +/**
>> + * ssam_nf_refcount_enable() - Disable event for reference count entry if it is
>
> s/ssam_nf_refcount_enable/ssam_nf_refcount_disable_free/
>
> No need to resend, I'll fix this up when merging this series.

Oh right, thanks!

Regards,
Max

\
 
 \ /
  Last update: 2021-06-04 22:24    [W:0.050 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site