lkml.org 
[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] gpio: tegra186: Add ACPI support
On Wed, Jun 30, 2021 at 9:17 PM Akhil R <akhilrajeev@nvidia.com> wrote:
>
> Add ACPI module ID to probe the driver from the ACPI based bootloader
> firmware.

Thanks for an update, my comments below.
After addressing, feel free to add
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Change-Id: Id8e892f989e4ccc935b87aa0d84b10a3d1efd8f9

This is not for upstream.

> Signed-off-by: Akhil Rajeev <akhilrajeev@nvidia.com>

...

> +static const struct acpi_device_id tegra186_gpio_acpi_match[] = {
> + { .id = "NVDA0108", .driver_data = (kernel_ulong_t)&tegra186_main_soc },
> + { .id = "NVDA0208", .driver_data = (kernel_ulong_t)&tegra186_aon_soc },
> + { .id = "NVDA0308", .driver_data = (kernel_ulong_t)&tegra194_main_soc },
> + { .id = "NVDA0408", .driver_data = (kernel_ulong_t)&tegra194_aon_soc },

> + {},

Comma is not needed for terminator lines.

> +};
> +MODULE_DEVICE_TABLE(acpi, tegra186_gpio_acpi_match);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-06-30 20:25    [W:0.076 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site