[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mmc: dw_mmc: Add data CRC error injection
Hi Vincent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.13 next-20210630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: 007b350a58754a93ca9fe50c498cc27780171153
config: arm-buildonly-randconfig-r005-20210630 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Vincent-Whitchurch/mmc-dw_mmc-Add-data-CRC-error-injection/20210630-182344
git checkout c77ecd0f5373a88c7f00191136827f5bc42f3948
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

drivers/mmc/host/dw_mmc.c: In function 'dw_mci_start_fault_timer':
>> drivers/mmc/host/dw_mmc.c:1826:21: error: implicit declaration of function 'prandom_u32' [-Werror=implicit-function-declaration]
1826 | ms_to_ktime(prandom_u32() % 25),
| ^~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/prandom_u32 +1826 drivers/mmc/host/dw_mmc.c

1812 static void dw_mci_start_fault_timer(struct dw_mci *host)
1813 {
1814 struct mmc_data *data = host->data;
1816 if (!data || data->blocks <= 1)
1817 return;
1819 if (!should_fail(&host->fail_data_crc, 1))
1820 return;
1822 /*
1823 * Try to inject the error at random points during the data transfer.
1824 */
1825 hrtimer_start(&host->fault_timer,
> 1826 ms_to_ktime(prandom_u32() % 25),
1828 }

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2021-06-30 16:31    [W:0.218 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site